Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heat solver using scalar framework - Part 1 #1844

Merged
merged 17 commits into from
Jan 11, 2023
Merged

Heat solver using scalar framework - Part 1 #1844

merged 17 commits into from
Jan 11, 2023

Conversation

pcarruscag
Copy link
Member

No description provided.

@pr-triage pr-triage bot added the PR: draft label Dec 6, 2022
@bigfooted
Copy link
Contributor

Nice work, looks good as always, so what is left for the WIP?

@pcarruscag
Copy link
Member Author

Quite a lot I think, boundary conditions, numerics, fixing the tests I broke.

@pcarruscag pcarruscag changed the title [WIP] Heat solver using scalar framework Heat solver using scalar framework - Part 1 Jan 9, 2023
@pcarruscag pcarruscag marked this pull request as ready for review January 9, 2023 15:19
WallyMaier
WallyMaier approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@WallyMaier WallyMaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pcarruscag pcarruscag merged commit 6dc9006 into develop Jan 11, 2023
@pcarruscag pcarruscag deleted the heat_solver_using_scalar_stuff branch January 11, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WallyMaier WallyMaier WallyMaier approved these changes

Assignees
No one assigned
Labels
changelog:chore PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcarruscag @bigfooted @WallyMaier